-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E tests #414
E2E tests #414
Conversation
…rra-classic into dong/e2eIbcHooks
…rra-classic into dong/e2eIbcHooks
You mean the upgrade handler is out of scope? Because without the upgrade handler this can't be used in production as the chain upgrade would fail. |
@StrathCole I mean the upgrade test is not in the current scope that we proposed. Of course we will do that, but it will be in an another proposal that we gonna submit to community. |
Just to make sure we don't misunderstand each other. I am not referring to the upgrade test, I mean the upgrade handler to register the key store you are using with PFM/interchain. So if I do |
That's might because we haven't had the v7 upgrade (or v6.2) which includes new added store for ibc-hooks and pfm, and the scripts above of yours didn't include the gov for the v7 upgrade. |
That was exactly what I meant 😃 |
I have added the v7 upgrade handler and tested locally |
@expertdicer looks like upgrade test now also passes 👍 |
I find these three PRs: containing overlapped logic to test pfm and ibc - hooks, so three times in total. Can you guys close two others and use this instead? Please provide reasons if this is not the case |
@nghuyenthevinh2000 You are free to close the localnet one, this is merely our first step toward getting ready for the tests and is not part of our PPJ scope. |
will be merging - snyk test will be handled in base branch |
a5d31c6
into
classic-terra:frag/foundation
Summary of changes
The e2e package defines an integration testing suite used for full end-to-end testing functionality. This package is decoupled from depending on the Terra codebase. It initializes the chains for testing via Docker files. As a result, the test suite may provide the desired Terra version to Docker containers during the initialization.
The file e2e_setup_test.go defines the testing suite and contains the core bootstrapping logic that creates a testing environment via Docker containers. A testing network is created dynamically with 2 test validators.
The file e2e_test.go contains the actual end-to-end integration tests that utilize the testing suite.
In E2E test, we added 3 tests which check the workflow of ibc-hooks, pfm and the original feetax design.